Merged
Conversation
this looks like a scary large change, but it really does the following - group installation methods by target (environment, editor, project) - add Home Manager and `mkShell` - simplify the examples for `treefmt-nix` and `git-hooks.nix` - add admonitions for the samples that require `treefmt` in the environment - remove `nix-env`, because that's the easiest way to discourage its use - move `nix fmt` to the end, because it takes much space for little benefit (interactive use is impractical: invoking it requires a full evaluation every time, while all environment and auto-config options run instantly)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2025-04-29/63649/1 |
jfly
reviewed
Apr 30, 2025
jfly
reviewed
Apr 30, 2025
jfly
approved these changes
May 9, 2025
Collaborator
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
LGTM. There's room for future improvement, which we'll deal with later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this looks like a scary large change, but it really does the following:
mkShelltreefmt-nixandgit-hooks.nixtreefmtin theenvironment
nix-env, because that's the easiest way to discourage its usenix fmtto the end, because it takes much space for little benefit(interactive use is impractical: invoking it requires a full evaluation every time,
while all environment and auto-config options run instantly)